feat(bigquery): expose customer managed encryption key for ML models#9302
Merged
tswast merged 8 commits intogoogleapis:masterfrom Oct 16, 2019
Merged
Conversation
googlebot
added
the
cla: yes
tswast
requested changes
Sep 26, 2019
| from google.api_core import datetime_helpers | ||
| from google.cloud.bigquery import _helpers | ||
| from google.cloud.bigquery_v2 import types | ||
| from google.cloud.bigquery.table import EncryptionConfiguration |
Contributor
There was a problem hiding this comment.
It seems wrong for EncryptionConfiguration to live in the table module now that it's used for tables and models. Let's create a new encryption_configuration model for this to live. (Similar to external_config.)
We can make an alias in the table module to keep this from being a breaking change.
| import google.cloud._helpers | ||
| from google.cloud.bigquery_v2.gapic import enums | ||
|
|
||
| KMS_KEY_NAME = "projects/1/locations/global/keyRings/1/cryptoKeys/1" |
Contributor
There was a problem hiding this comment.
I know this is a unit test, but we're supposed to discourage use of global location. Let's change this to us.
HemangChothani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
@tswast PTAL. |
…hange location in key
tswast
reviewed
Oct 14, 2019
| self._verify_field(field, r_field) | ||
|
|
||
|
|
||
| class TestEncryptionConfiguration(unittest.TestCase): |
Contributor
There was a problem hiding this comment.
Can we please keep one test to ensure that from google.cloud.bigquery.table import EncryptionConfiguration continues to work? I don't want to make this feature into breaking change.
tswast
requested changes
Oct 15, 2019
|
|
||
| def test_encryption_configuration_setter(self): | ||
| from google.cloud.bigquery.table import EncryptionConfiguration | ||
| from google.cloud.bigquery.encryption_configuration import ( |
Contributor
There was a problem hiding this comment.
I meant that we need to test that the old location needs to continue to work.
Suggested change
| from google.cloud.bigquery.encryption_configuration import ( | |
| # Previously, the EncryptionConfiguration class was in the table module, not the | |
| # encryption_configuration module. It was moved to support models encryption. | |
| # This test import from the table module to ensure that the previous location | |
| # continues to function as an alias. | |
| from google.cloud.bigquery.table import ( |
tswast
approved these changes
Oct 16, 2019
HemangChothani
deleted the
Bigquery_expose_CMEK_functionality_for_ML_models
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9251